update

consul/discovery.go

@@ -17,26 +17,35 @@ type Service struct {
 	appID      string
 	domain     string
 	pathPrefix string
+	tls        bool
 	port       int
 	ttl        time.Duration
 	client     *consul.Client
 	agent      *consul.Agent
 	connect    *connect.Service
 	kv         *consul.KV
+
+	// hcTicker  *time.Ticker
+	// ttlTicker *time.Ticker
 }
 
 var ErrServiceUnavailable = fmt.Errorf("Service is unavailable")
 
-func NewService(servAddr, id, name, hostname, domain, pathPrefix string, appPort int) (*Service, error) {
+func NewService(servAddr, id, name, useDomainOverIp, addr, domain, pathPrefix string, appPort int) (*Service, error) {
 	s := new(Service)
 	s.Name = name
-	s.Address = hostname
+	s.Address = addr
 	s.appID = id
 	s.domain = domain
 	s.pathPrefix = pathPrefix
+	s.tls = true // FIXME add arg
 	s.port = appPort
 	s.ttl = time.Second * 10
 
+	if useDomainOverIp == "true" { // FIXME types...
+		s.Address = domain
+	}
+
 	client, err := consul.NewClient(newClientConfig(servAddr))
 	if err != nil {
 		return nil, err
@@ -61,9 +70,8 @@ func (s *Service) GetID() string {
 }
 
 func (s *Service) GetFullAddr() string {
-	isTLS := s.port == 443
 	proto := "http"
-	if isTLS {
+	if s.tls {
 		proto = "https"
 	}
 	return fmt.Sprintf("%s://%s:%d/", proto, s.domain, s.port)
@@ -77,11 +85,13 @@ func (s *Service) Register() error {
 		Address: s.Address,
 		Port:    s.port,
 		Tags:    s.getTags(),
-		// Connect: &consul.AgentServiceConnect{Native: true},
+		Connect: &consul.AgentServiceConnect{Native: true},
 		// Proxy: &consul.AgentServiceConnectProxyConfig{
 		// 	DestinationServiceName: s.Name,
 		// },
 		Check: &consul.AgentServiceCheck{
+			// Interval:                       "5s",
+			// Timeout:                        "1s",
 			TTL:                            s.ttl.String(),
 			Status:                         "passing",
 			DeregisterCriticalServiceAfter: "10s",
@@ -95,30 +105,33 @@ func (s *Service) Register() error {
 	return nil
 }
 func (s *Service) Unregister() error {
-	// s.client.Catalog().Deregister(&consul.CatalogDeregistration{
-	// 	Address:   s.Address,
-	// 	ServiceID: s.GetID(),
-	// }, nil)
+	// s.ttlTicker.Stop()
+	// s.hcTicker.Stop()
+
+	s.client.Catalog().Deregister(&consul.CatalogDeregistration{
+		Address:   s.Address,
+		ServiceID: s.GetID(),
+	}, nil)
 
 	return s.agent.ServiceDeregister(s.GetID())
 }
 
 func (s *Service) RegisterHealthChecks() {
 	go func() { // startup register
-		ticker := time.NewTicker(time.Second * 1)
-		for range ticker.C {
+		t := time.NewTicker(time.Second)
+		for range t.C {
 			if ok, _ := s.healthCheck(); ok {
-				ticker.Stop()
+				t.Stop()
 			}
 		}
 	}()
 
 	go func() { // TTL
-		interval := s.ttl - (time.Second * 2) // 2 seconds overhead
-		ticker := time.NewTicker(interval)
-		for range ticker.C {
+		t := time.NewTicker(s.ttl)
+		for range t.C {
 			if _, err := s.healthCheck(); err != nil {
-				fmt.Printf("HealthCheck endpoint not available #: %v\n", err)
+				// fmt.Printf("HealthCheck endpoint not available (%s)#: %v\n", s.GetFullAddr(), err)
+				t.Stop()
 			}
 		}
 	}()
@@ -131,11 +144,10 @@ func (s *Service) Connect() (*connect.Service, error) {
 	// })
 	svc, err := connect.NewService(s.Name, s.client)
 	s.connect = svc
-	cnf := svc.ServerTLSConfig()
-	fmt.Printf("CONNECT SERVER:: %s CONFIG:: %v\n", s.Name, cnf)
-	for k, c := range cnf.Certificates {
-		fmt.Printf("CONNECT CERT %d: %v", k, c)
-	}
+	fmt.Printf("CONNECT SERVER:: %s CERTS:: %v\n", s.Name, svc.ServerTLSConfig())
+	// for k, c := range cnf.Certificates {
+	// 	fmt.Printf("CONNECT CERT %d: %v", k, c)
+	// }
 
 	return svc, err
 }
@@ -148,6 +160,7 @@ func (s *Service) healthCheck() (bool, error) {
 	alive := func() bool {
 		client := &http.Client{}
 		healthUrl := fmt.Sprintf("%s%s?name=%s", s.GetFullAddr(), "health", s.Name)
+		// fmt.Printf("HealthCheck URL: %s%s?name=%s", s.GetFullAddr(), "health", s.Name)
 		req, err := http.NewRequest(http.MethodGet, healthUrl, nil)
 		if err != nil {
 			return false
@@ -186,24 +199,25 @@ func (s *Service) getTags() []string {
 		// "traefik.http.middlewares.auth_" + s.Name + ".forwardauth.trustForwardHeader=true",
 		// "traefik.http.middlewares.auth_" + s.Name + ".forwardauth.authRequestHeaders=Cookie",
 		// "traefik.http.middlewares.auth_" + s.Name + ".forwardauth.authResponseHeaders=Set-Cookie, Server",
-		"traefik.http.middlewares.auth_" + s.Name + ".plugin.auth.handlerURL=" + config.GetEnv("AUTH_HANDLER_URL", "http://identity.service.ego.io/api/v1/traefik"),
-		"traefik.http.middlewares.requestid_" + s.Name + ".plugin.requestid.headerName=X-Request-ID",
+		"traefik.http.middlewares.auth_" + s.Name + ".plugin.auth.handlerURL=" + config.GetEnv("AUTH_HANDLER_URL", "https://identity.service.ego.io/api/v1/traefik"),
 		"traefik.http.middlewares.stripprefix_" + s.Name + ".stripprefix.prefixes=" + s.pathPrefix,
-		"traefik.http.routers." + s.Name + ".rule=PathPrefix(`" + s.pathPrefix + "`)",
-		// "traefik.http.routers." + s.Name + ".rule=Host(`" + s.domain + "`)",
+		"traefik.http.middlewares.requestid_" + s.Name + ".plugin.requestid.headerName=X-Request-ID",
+		// "treafik.http.middlewares.retryif_" + s.Name + ".plugin.retryif.attempts=3",
+		// "treafik.http.middlewares.retryif_" + s.Name + ".plugin.retryif.statusCode=503",
+		"traefik.http.routers." + s.Name + ".rule=Host(`" + s.domain + "`) && PathPrefix(`" + s.pathPrefix + "`)",
 		"traefik.http.routers." + s.Name + ".entryPoints=https",
-		// "traefik.http.routers." + s.Name + ".tls=true",
+		"traefik.http.routers." + s.Name + ".tls=true",
 		"traefik.http.routers." + s.Name + ".service=" + s.Name,
 		// "traefik.http.routers." + s.Name + ".middlewares=auth_" + s.Name + ",stripprefix_" + s.Name,
-		"traefik.http.routers." + s.Name + ".middlewares=auth_" + s.Name + ",requestid_" + s.Name + ",stripprefix_" + s.Name + "",
-		"traefik.http.services." + s.Name + ".loadbalancer.server.scheme=http",
+		"traefik.http.routers." + s.Name + ".middlewares=auth_" + s.Name + ",stripprefix_" + s.Name + ",requestid_" + s.Name + "",
+		"traefik.http.services." + s.Name + ".loadbalancer.server.scheme=https",
 		"traefik.http.services." + s.Name + ".loadbalancer.server.port=" + strconv.Itoa(s.port),
 		"traefik.http.services." + s.Name + ".loadbalancer.passhostheader=true",
-		"traefik.http.services." + s.Name + ".loadbalancer.healthcheck.interval=1s",
+		"traefik.http.services." + s.Name + ".loadbalancer.healthcheck.interval=5s",
 		"traefik.http.services." + s.Name + ".loadbalancer.healthcheck.timeout=1s",
 		"traefik.http.services." + s.Name + ".loadbalancer.healthcheck.path=/health",
-		"traefik.tls.certificates.certfile=/certs/client.cert",
-		"traefik.tls.certificates.keyfile=/certs/client.key",
+		"traefik.tls.certificates.certfile=certs/client.crt",
+		"traefik.tls.certificates.keyfile=certs/client.key",
 	}
 
 	return tags

go.mod

@@ -1,9 +1,9 @@
-module git.pbiernat.io/egommerce/go-api-pkg
+module git.ego.cloudns.be/egommerce/go-api-pkg
 
 go 1.18
 
 require (
-	git.pbiernat.io/egommerce/api-entities v0.2.3
+	git.ego.cloudns.be/egommerce/api-entities v0.2.3
 	github.com/fluent/fluent-logger-golang v1.9.0
 	github.com/go-redis/redis/v8 v8.11.5
 	github.com/hashicorp/consul v1.16.0