consul fixes

consul/discovery.go

@@ -61,7 +61,12 @@ func (s *Service) GetID() string {
 }
 
 func (s *Service) GetFullAddr() string {
-	return fmt.Sprintf("https://%s:%d/", s.domain, s.port)
+	isTLS := s.port == 443
+	proto := "http"
+	if isTLS {
+		proto = "https"
+	}
+	return fmt.Sprintf("%s://%s:%d/", proto, s.domain, s.port)
 }
 
 func (s *Service) Register() error {
@@ -72,12 +77,7 @@ func (s *Service) Register() error {
 		Address: s.Address,
 		Port:    s.port,
 		Tags:    s.getTags(),
-		Connect: &consul.AgentServiceConnect{
-			Native: true,
-			// SidecarService: &consul.AgentServiceRegistration{
-			// 	Port: s.port,
-			// },
-		},
+		// Connect: &consul.AgentServiceConnect{Native: true},
 		// Proxy: &consul.AgentServiceConnectProxyConfig{
 		// 	DestinationServiceName: s.Name,
 		// },
@@ -98,7 +98,7 @@ func (s *Service) Unregister() error {
 	return s.agent.ServiceDeregister(s.GetID())
 }
 
-func (s *Service) InitHealthChecks() {
+func (s *Service) RegisterHealthChecks() {
 	go func() { // startup register
 		ticker := time.NewTicker(time.Second * 1)
 		for range ticker.C {
@@ -109,7 +109,7 @@ func (s *Service) InitHealthChecks() {
 	}()
 
 	go func() { // TTL
-		interval := s.ttl - time.Second*2 // 2 seconds overhead
+		interval := s.ttl - (time.Second * 2) // 2 seconds overhead
 		ticker := time.NewTicker(interval)
 		for range ticker.C {
 			if _, err := s.healthCheck(); err != nil {
@@ -120,12 +120,14 @@ func (s *Service) InitHealthChecks() {
 }
 
 func (s *Service) Connect() (*connect.Service, error) {
-	// srvName := s.Name
-	srvName := s.Name
-	svc, err := connect.NewService(srvName, s.client)
+	// l := hclog.New(&hclog.LoggerOptions{
+	// 	Name:  "consul-registry",
+	// 	Level: hclog.Trace,
+	// })
+	svc, err := connect.NewService(s.Name, s.client)
 	s.connect = svc
 	cnf := svc.ServerTLSConfig()
-	fmt.Printf("CONNECT SERVER:: %s CONFIG:: %v\n", srvName, cnf)
+	fmt.Printf("CONNECT SERVER:: %s CONFIG:: %v\n", s.Name, cnf)
 	for k, c := range cnf.Certificates {
 		fmt.Printf("CONNECT CERT %d: %v", k, c)
 	}
@@ -147,17 +149,14 @@ func (s *Service) healthCheck() (bool, error) {
 		}
 		req.Header.Set("User-Agent", "service/internal")
 
-		fmt.Printf("Sending HEALTH CHECK request to: %s\n", healthUrl)
 		resp, err := client.Do(req)
 		if err != nil {
-			fmt.Printf("Sending HEALTH CHECK request error: %v\n", err)
 			return false
 		}
 		defer resp.Body.Close()
 
 		var body []byte
 		resp.Body.Read(body)
-		fmt.Printf("HEALTH CHECK response to: %v -- %v\n", resp, body)
 
 		return resp.StatusCode == http.StatusOK
 	}()
@@ -181,7 +180,7 @@ func (s *Service) getTags() []string {
 		"traefik.enable=true",
 		"traefik.http.routers." + s.Name + ".rule=PathPrefix(`" + s.pathPrefix + "`)",
 		"traefik.http.routers." + s.Name + ".entryPoints=https",
-		"traefik.http.routers." + s.Name + ".tls=true",
+		// "traefik.http.routers." + s.Name + ".tls=true",
 		"traefik.http.routers." + s.Name + ".service=" + s.Name,
 		"traefik.http.routers." + s.Name + ".middlewares=auth_" + s.Name + ",requestid_" + s.Name + ",stripprefix_" + s.Name,
 		"traefik.http.services." + s.Name + ".loadbalancer.server.scheme=http",