Consul refactor

consul/discovery.go

@@ -19,8 +19,8 @@ type Service struct {
 	port       int
 	ttl        time.Duration
 	agent      *consul.Agent
+	connect    *consul.Connect
 	kv         *consul.KV
-	catalog    *consul.Catalog
 }
 
 var ErrServiceUnavailable = fmt.Errorf("Service is unavailable")
@@ -33,15 +33,15 @@ func NewService(servAddr, id, name, hostname, domain, pathPrefix string, appPort
 	s.domain = domain
 	s.pathPrefix = pathPrefix
 	s.port = appPort
-	s.ttl = time.Second * 15
+	s.ttl = time.Second * 10
 
 	client, err := consul.NewClient(newClientConfig(servAddr))
 	if err != nil {
 		return nil, err
 	}
 	s.agent = client.Agent()
+	s.connect = client.Connect()
 	s.kv = client.KV()
-	s.catalog = client.Catalog()
 
 	return s, nil
 }
@@ -70,7 +70,7 @@ func (s *Service) Register() error {
 		Tags:    s.getTags(),
 		Check: &consul.AgentServiceCheck{
 			TTL:                            s.ttl.String(),
-			DeregisterCriticalServiceAfter: "5s",
+			DeregisterCriticalServiceAfter: "10s",
 		},
 	}
 
@@ -79,7 +79,7 @@ func (s *Service) Register() error {
 	}
 
 	go func(s *Service) { // startup register
-		ticker := time.NewTicker(time.Millisecond * 100)
+		ticker := time.NewTicker(time.Second * 1)
 		for range ticker.C {
 			if ok, _ := s.healthCheck(); ok {
 				ticker.Stop()
@@ -103,29 +103,26 @@ func (s *Service) Unregister() error {
 	return s.agent.ServiceDeregister(s.GetID())
 }
 
-func (s *Service) KV() *consul.KV {
-	return s.kv
+func (s *Service) Connect() *consul.Connect {
+	return s.connect
 }
 
-func (s *Service) Catalog() *consul.Catalog {
-	return s.catalog
+func (s *Service) KV() *consul.KV {
+	return s.kv
 }
 
 func (s *Service) healthCheck() (bool, error) {
 	alive := func() bool {
 		client := &http.Client{}
 		healthUrl := s.GetFullAddr() + "health"
-		fmt.Printf("Sending request to the %s\n", healthUrl)
 		req, err := http.NewRequest(http.MethodGet, healthUrl, nil)
 		if err != nil {
-			fmt.Printf("Failed to create new Consul request: %v\n", err)
 			return false
 		}
-		req.Header.Set("User-Agent", "Health Check")
+		req.Header.Set("User-Agent", "service/internal")
 
 		resp, err := client.Do(req)
 		if err != nil {
-			fmt.Printf("Failed to send Consul request: %v\n", err)
 			return false
 		}
 		defer resp.Body.Close()
@@ -135,6 +132,7 @@ func (s *Service) healthCheck() (bool, error) {
 
 	if alive {
 		if err := s.agent.PassTTL("service:"+s.GetID(), "OK"); err != nil {
+			fmt.Printf("Failed to pass TTL: %v", err)
 			return false, err
 		}
 		return true, nil